Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload source distribution #1586

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Upload source distribution #1586

wants to merge 3 commits into from

Conversation

julianschuler
Copy link
Member

Why? What?

This PR adds also uploading the source code when uploading to a NAO to allow for reproducible build of e.g. the replayer at a later stage.

Blocked on #1486.

ToDo / Known Issues

None.

Ideas for Next Iterations (Not This PR)

Currently the whole repository except the webots folder is uploaded. We should consider whether we want to exclude other subfolders like e.g. tools.

How to Test

Upload to a NAO, connect to it and observe the source code in the hulk/source subfolder.

@julianschuler
Squashed commit of the following:
59e76a3 
commit 1961236
Author: Julian Schuler <[email protected]>
Date:   Sun Jan 12 10:53:51 2025 +0100

    Directly build tokio command instead of converting

commit 406d028
Author: Julian Schuler <[email protected]>
Date:   Sun Jan 12 10:47:11 2025 +0100

    Fix storing incorrect address in twix

commit 39e7ebd
Author: Konrad Nölle <[email protected]>
Date:   Sat Jan 11 20:44:00 2025 +0100

    Fix relative pwd for remote cargo actions

commit 860ab8b
Author: Maximilian Schmidt <[email protected]>
Date:   Sat Jan 11 19:04:13 2025 +0100

    fix duplicated os check

commit 713a93c
Author: Maximilian Schmidt <[email protected]>
Date:   Sat Jan 11 13:00:59 2025 +0100

    rework commands

commit 3d12ade
Author: Maximilian Schmidt <[email protected]>
Date:   Sat Jan 11 10:31:30 2025 +0100

    streamline logging

commit abb991f
Author: Julian Schuler <[email protected]>
Date:   Sat Jan 11 00:00:51 2025 +0100

    Fix using incorrect manifest for update check

commit 24a52a8
Author: Julian Schuler <[email protected]>
Date:   Fri Jan 10 23:55:41 2025 +0100

    Use manifest path for checking lock files

commit 1def48f
Author: Julian Schuler <[email protected]>
Date:   Fri Jan 10 23:55:15 2025 +0100

    Update Cargo.lock files

commit d5abc7b
Author: Julian Schuler <[email protected]>
Date:   Fri Jan 10 23:40:36 2025 +0100

    Remove unused tests and implementations

commit 9f46d8d
Author: Julian Schuler <[email protected]>
Date:   Fri Jan 10 23:19:18 2025 +0100

    Update CI to make use of new pepsi functionality

commit 7b75e88
Author: Julian Schuler <[email protected]>
Date:   Fri Jan 10 23:09:35 2025 +0100

    Add manifest shortcuts for all tools and services

commit d6bdd5f
Author: Julian Schuler <[email protected]>
Date:   Fri Jan 10 23:07:55 2025 +0100

    Remove unused fallback URL for HULK OS image

commit 1d49c74
Author: Julian Schuler <[email protected]>
Date:   Fri Jan 10 23:07:14 2025 +0100

    Move parameter tester to tools

commit b9d5d5a
Author: Julian Schuler <[email protected]>
Date:   Fri Jan 10 22:35:05 2025 +0100

    Update documentation

commit 4a7e7f4
Author: Julian Schuler <[email protected]>
Date:   Fri Jan 10 17:15:58 2025 +0100

    Reenable softbank NAO login script

commit 42e62af
Author: Julian Schuler <[email protected]>
Date:   Fri Jan 10 17:02:34 2025 +0100

    Implement remote host

commit 2f93969
Author: Julian Schuler <[email protected]>
Date:   Fri Jan 10 16:45:04 2025 +0100

    Use relative manifest path

commit 172e0c3
Author: Julian Schuler <[email protected]>
Date:   Fri Jan 10 16:41:54 2025 +0100

    Bump SDK and OS version in hulk.toml

commit 81a595f
Author: Julian Schuler <[email protected]>
Date:   Fri Jan 10 16:37:05 2025 +0100

    Fix incorrect paths to hula types

commit 81ff8ad
Author: Julian Schuler <[email protected]>
Date:   Fri Jan 10 15:04:45 2025 +0100

    Add pepsi install

commit acf09b4
Author: Julian Schuler <[email protected]>
Date:   Thu Jan 9 23:32:44 2025 +0100

    Fix incorrect error message

    Co-authored-by: Maximilian Schmidt <[email protected]>

commit 8a117ef
Author: Julian Schuler <[email protected]>
Date:   Thu Jan 9 23:27:42 2025 +0100

    Implement pepsi test

    Co-authored-by: Maximilian Schmidt <[email protected]>

commit fe91618
Author: Julian Schuler <[email protected]>
Date:   Thu Jan 9 23:26:48 2025 +0100

    Apply manifest path directly after sub command

    Co-authored-by: Maximilian Schmidt <[email protected]>

commit 415d9f1
Author: Julian Schuler <[email protected]>
Date:   Thu Jan 9 23:04:43 2025 +0100

    Update pepsi subcommand docstrings

    Co-authored-by: Maximilian Schmidt <[email protected]>

commit 0338dd9
Author: Julian Schuler <[email protected]>
Date:   Thu Jan 9 22:55:17 2025 +0100

    Output used cargo environment

    Co-authored-by: Maximilian Schmidt <[email protected]>

commit 004b23b
Author: Julian Schuler <[email protected]>
Date:   Thu Jan 9 22:54:44 2025 +0100

    Parse cargo environment from package metadata

    Co-authored-by: Maximilian Schmidt <[email protected]>

commit bf171e8
Author: Julian Schuler <[email protected]>
Date:   Thu Jan 9 21:59:22 2025 +0100

    Fix finding repository root in bevyhavior simulator

commit 68553e3
Author: Julian Schuler <[email protected]>
Date:   Thu Jan 9 21:33:49 2025 +0100

    Move cargo arguments to corresponding module

commit 2d78f28
Author: Julian Schuler <[email protected]>
Date:   Thu Jan 9 21:28:29 2025 +0100

    Setup cargo environment before executing cargo

    Co-authored-by: Maximilian Schmidt <[email protected]>

commit 8a6cdb1
Author: Julian Schuler <[email protected]>
Date:   Thu Jan 9 21:28:02 2025 +0100

    Remove deprecated fallback URL

    Co-authored-by: Maximilian Schmidt <[email protected]>

commit 74867c1
Author: Julian Schuler <[email protected]>
Date:   Thu Jan 9 21:15:07 2025 +0100

    Do not expose manifest path for pre game and upload

    Co-authored-by: Maximilian Schmidt <[email protected]>

commit b81cae5
Author: Julian Schuler <[email protected]>
Date:   Thu Jan 9 21:14:36 2025 +0100

    Use qualified paths instead of renaming

    Co-authored-by: Maximilian Schmidt <[email protected]>

commit 32489f8
Author: Julian Schuler <[email protected]>
Date:   Thu Jan 9 21:12:31 2025 +0100

    Use OsString instead of String for manifest

    Co-authored-by: Maximilian Schmidt <[email protected]>

commit f53c785
Author: Julian Schuler <[email protected]>
Date:   Thu Jan 9 18:18:48 2025 +0100

    Remove unused imports

    Co-authored-by: Maximilian Schmidt <[email protected]>

commit f31170e
Author: Julian Schuler <[email protected]>
Date:   Thu Jan 9 18:17:13 2025 +0100

    Add manifest flag for cargo commands

    Co-authored-by: Maximilian Schmidt <[email protected]>

commit dbe6bf4
Author: Julian Schuler <[email protected]>
Date:   Thu Jan 9 17:31:14 2025 +0100

    Finish pepsi pregame implementation

    Co-authored-by: Maximilian Schmidt <[email protected]>

commit 032a27e
Author: Julian Schuler <[email protected]>
Date:   Thu Jan 9 17:30:33 2025 +0100

    Reimplement pepsi upload

    Co-authored-by: Maximilian Schmidt <[email protected]>

commit 1941835
Author: Julian Schuler <[email protected]>
Date:   Thu Jan 9 17:02:00 2025 +0100

    Update cargo profiles

    Co-authored-by: Maximilian Schmidt <[email protected]>

commit 7a25ebc
Author: Julian Schuler <[email protected]>
Date:   Thu Jan 9 14:57:42 2025 +0100

    Skip downloading SDK installer if already present

commit 43f0db9
Author: Julian Schuler <[email protected]>
Date:   Thu Jan 9 13:46:40 2025 +0100

    Implement resolving environment from CLI arguments

commit 06acbbe
Author: Julian Schuler <[email protected]>
Date:   Thu Jan 9 12:39:56 2025 +0100

    Deduplicate cargo commands with shared trait

commit d1118c2
Author: Julian Schuler <[email protected]>
Date:   Thu Jan 9 12:22:50 2025 +0100

    Implement cargo commands

commit c4202e7
Author: Maximilian Schmidt <[email protected]>
Date:   Tue Dec 17 16:47:30 2024 +0100

    --wip--

commit 5e75b83
Author: Maximilian Schmidt <[email protected]>
Date:   Sun Nov 3 22:13:32 2024 +0100

    rework documentation and error messages

commit 0ec7188
Author: Maximilian Schmidt <[email protected]>
Date:   Sun Nov 3 13:27:14 2024 +0100

    Things work
@julianschuler
Tar and upload source distribution
c517077
@julianschuler
Upload source distribution directly using rsync
c8b843a
@oleflb oleflb added is:Blocked This is blocked because something prevents a merge. is:Dependent This is blocked because something else needs to happen first. and removed is:Blocked This is blocked because something prevents a merge. labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@knoellle knoellle

Labels
is:Dependent This is blocked because something else needs to happen first.
Projects
Development
Status: Request for Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julianschuler @knoellle @oleflb